coturn: refactor resource labels, expose ServiceMonitor for metrics endpoint#2677
Merged
coturn: refactor resource labels, expose ServiceMonitor for metrics endpoint#2677
Conversation
This adds the labels app, chart, heritage, and release to the coturn chart (same as the wire-server charts), and removes the boilerplate for overriding resource names.
The Service is headless, so this port is not exposed to the outside world; this is required so that the metrics endpoint is visible to the metrics collection agent which consumes the ServiceMonitor.
akshaymankar
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces an option to the coturn Helm chart to install a
ServiceMonitorresource, to expose the metrics endpoints on coturn pods to a third-party metrics collection agent, such asgrafana-agent.As a side-effect, I've refactored the labels which are applied to Kubernetes resources in this chart, so they are consistent with the conventions in the wire-server charts (e.g. use
appinstead ofwireServiceorapp.kubernetes.io/name-- see #2413)Checklist
changelog.d